Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vegcover and albedo #31

Open
tbohn opened this issue Feb 2, 2016 · 3 comments
Open

Add support for vegcover and albedo #31

tbohn opened this issue Feb 2, 2016 · 3 comments
Labels

Comments

@tbohn
Copy link
Contributor

tbohn commented Feb 2, 2016

In 4.2 and 5.0 classic, vegcover optionally can be in the veg_lib and both vegcover and albedo can be in the veg_param file. This needs to be handled in tonic.

This also involves changing the logic for options - currently there is just a flag for global_lai (or lai_index in some cases) but this needs to be replaced by the set {veglib_vegcover, vegparam_lai, vegparam_vegcover, vegparam_albedo, lai_src, vegcover_src, and albedo_src}. global_lai would correspond to vegparam_lai = true and lai_src = from_vegparam.

@tbohn
Copy link
Contributor Author

tbohn commented Feb 20, 2016

This was addressed by PR #40 but for some reason didn't get automatically closed. It can be closed now.

@tbohn
Copy link
Contributor Author

tbohn commented Feb 20, 2016

Wait, never mind. The reason it didn't get closed was because I said it shouldn't be closed yet. The idea being that this issue pertains to the reverse direction (netcdf to ascii) as well as ascii to netcdf, and this hasn't been addressed yet.

@tbohn
Copy link
Contributor Author

tbohn commented Mar 21, 2016

The ascii-netcdf conversion aspect of this issue has been addressed in PR #40. The netcdf-ascii conversion aspect of this issue has been moved into a new issue #44. Thus, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants