Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› Enhance Models code snippets #374

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

yashksaini-coder
Copy link
Contributor

βœ… Closes: #361

This pull request includes extensive changes to the pysnippets machine learning models and their corresponding tests. The main updates involve adding logging for better tracking and error handling, enhancing docstrings for clarity, and removing old test files.

Enhancements to models:

  • Added logging to track initialization, fitting, prediction, and scoring processes in all models (pysnippets/models/CV_means.py, pysnippets/models/Catboost.py, pysnippets/models/Ensemble.py, pysnippets/models/Grid_search.py, pysnippets/models/KMeans.py, pysnippets/models/LightGBM.py, pysnippets/models/Linear_regression.py, pysnippets/models/Logistic_regression.py, pysnippets/models/XGB.py). [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Enhanced docstrings to provide detailed descriptions of classes and methods, including parameters and return types (pysnippets/models/CV_means.py, pysnippets/models/Catboost.py, pysnippets/models/Ensemble.py, pysnippets/models/Grid_search.py, pysnippets/models/KMeans.py, pysnippets/models/LightGBM.py, pysnippets/models/Linear_regression.py, pysnippets/models/Logistic_regression.py, pysnippets/models/XGB.py). [1] [2] [3] [4] [5] [6] [7] [8] [9]

Test file removals:

  • Removed old test files for machine learning models (Tests/machine-learning-test/test_CV_means.py, Tests/machine-learning-test/test_Catboost.py, Tests/machine-learning-test/test_Ensemble.py, Tests/machine-learning-test/test_Grid_search.py, Tests/machine-learning-test/test_KMeans.py, Tests/machine-learning-test/test_LightGBM.py, Tests/machine-learning-test/test_Linear.py, Tests/machine-learning-test/test_Logistic.py, Tests/machine-learning-test/test_XGB.py). [1] [2] [3] [4] [5] [6] [7] [8] [9]

Initialization of models module:

  • Added imports for all models in the __init__.py file to facilitate easier access (pysnippets/models/__init__.py).

@UTSAVS26 kindly review this PR.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

πŸ‘‹ Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@UTSAVS26 UTSAVS26 merged commit 936a5b5 into UTSAVS26:main Nov 8, 2024
2 of 6 checks passed
@yashksaini-coder yashksaini-coder deleted the fix-361 branch November 8, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance ML Models code snippet
2 participants