Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: discretization.query #343

Open
mathematicalmichael opened this issue Jul 9, 2019 · 2 comments
Open

TODO: discretization.query #343

mathematicalmichael opened this issue Jul 9, 2019 · 2 comments
Assignees

Comments

@mathematicalmichael
Copy link
Collaborator

Check out line 1072 in sample.py... this appears to be a situation where a function was never finished. Not entirely sure what this means, since a discretization holds three different sample sets, so this could be querying any one of them.

It's a null-function. What was this function supposed to do? Should we remove it?
I already have functions coming down the pipeline that make getting input/output easier
get_input().query() etc would be the appropriate call.

1069     def query(self, x, k=1):
1070         """
1071         Identify which value points x are associated with for discretization.
1072
1073         :param x: points for query
1074         :type x: :class:`numpy.ndarray` of shape ``(*, dim)``
1075         :param int k: number of nearest neighbors to return
1076
1077         """
1078         pass
@smattis
Copy link
Contributor

smattis commented Nov 22, 2019

I will take care of this.

@mathematicalmichael
Copy link
Collaborator Author

did this get handled in v3? I lost track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants