Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wntr.network.io.valid_gis_names(True) contains some values that are not valid GIS Names #449

Closed
angusmcb opened this issue Sep 27, 2024 · 3 comments
Assignees
Labels

Comments

@angusmcb
Copy link
Contributor

Summary
wntr.network.io.valid_gis_names(True) contains some values that are not valid GIS Names.

Specifically:

  • junctions, tanks, and reservoirs contain coordinates which is not a valid GIS name - these are derived from the geometry
  • pipes, pumps and valves contain vertices , similarly this is derived from the geometry
  • tanks contains min_volvol_curve_name which I think is just a typo

Environment
Provide information on your computing environment.

  • WNTR version: 1.2.0
@angusmcb
Copy link
Contributor Author

angusmcb commented Oct 4, 2024

Also 'power' and 'base_speed' for pumps

@kaklise
Copy link
Collaborator

kaklise commented Oct 7, 2024

Thanks for posting this issue, this should be an easy fix. I'll check in an update soon.

@kaklise
Copy link
Collaborator

kaklise commented Nov 13, 2024

Closed by #452

@kaklise kaklise closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants