You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary
I found a possible minor error while reading the WNTR source code, so I would like to ask if it belongs to a clerical error or has other meanings. I would greatly appreciate receiving your reply.
The problem is as follows:
(Error in Version 0.4.2) There is a TimeOpiton Class in wntr.network.options Module, the comment for the timestamp parameter states that the default value is 360 seconds, but the parentheses indicate 5 minutes later. We can see in the code that the initial value of this parameter is set to 360 (seconds).
(Error in Version 1.10) There are two parameters in Class TimeOpiton , named quality Timestep_ and rule Timestep_. It was mentioned in the comment that the default value for this parameter is 360 (seconds), but the parentheses in the comment state 5 minutes.
Are there any errors in this?
Example
[Optional] Include an example. The example can use INP files from the examples folder.
Environment
[Optional] Provide information on your computing environment.
Operating system:
Python version: 3.7 / 3.9
WNTR version: 0.4.2 / 1.1.0
The text was updated successfully, but these errors were encountered:
Thanks for catching this. These values should match the EPANET default values of 6 minutes (1/10 of the hydraulic timestep). The values are correct, but we need to update the documentation.
Summary
I found a possible minor error while reading the WNTR source code, so I would like to ask if it belongs to a clerical error or has other meanings. I would greatly appreciate receiving your reply.
The problem is as follows:
(Error in Version 0.4.2) There is a TimeOpiton Class in wntr.network.options Module, the comment for the timestamp parameter states that the default value is 360 seconds, but the parentheses indicate 5 minutes later. We can see in the code that the initial value of this parameter is set to 360 (seconds).
(Error in Version 1.10) There are two parameters in Class TimeOpiton , named quality Timestep_ and rule Timestep_. It was mentioned in the comment that the default value for this parameter is 360 (seconds), but the parentheses in the comment state 5 minutes.
Are there any errors in this?
Example
[Optional] Include an example. The example can use INP files from the examples folder.
Environment
[Optional] Provide information on your computing environment.
The text was updated successfully, but these errors were encountered: