Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore Tab will crash if too many sites are selected #192

Open
cristinamullin opened this issue Dec 5, 2024 · 0 comments
Open

Explore Tab will crash if too many sites are selected #192

cristinamullin opened this issue Dec 5, 2024 · 0 comments
Assignees

Comments

@cristinamullin
Copy link
Collaborator

Describe the bug

The application will crash on the Explore tab if too many sites are selected for mapping.

To Reproduce

Steps to reproduce the behavior:

  1. Run query with the following WQP filter inputs:
  • countrycode: Atlantic Ocean and Pacific Ocean
  • sampleMedia: "Water" "water"
  • providers: "NWIS" "STORET"
image
  1. Run Tests on flag tab

  2. Skip ahead to explore tab

  3. Generate Groups with TADA.ComparableDataIdentifier entered as the grouping column

image
  1. Generate Map for "PLASTICS #/100ML
image

This is when the app crashes and you get the error below:

Error: (converted from warning) Error in : (converted from warning) Error in : (converted from warning) The select input "figures_1-selsites1" contains a large number of options; consider using server-side selectize for massively improved performance. See the Details section of the ?selectizeInput help topic.

Expected behavior

The app should not crash.

If you enter ?selectizeInput to the console. There are instructions here on how to change this to a server side selectize input instead: https://shiny.posit.co/r/articles/build/selectize/

This pertains to what we currently have in line 532 of mod_figures.R
shiny::selectizeInput(ns("selsites1"), "Select sites", choices = sites, selected = sites[1], multiple = TRUE, width = "100%")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants