Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'outflow' value in getNodeValue method #168

Open
jubilee2 opened this issue Mar 19, 2024 · 3 comments · May be fixed by #196
Open

Support for 'outflow' value in getNodeValue method #168

jubilee2 opened this issue Mar 19, 2024 · 3 comments · May be fixed by #196
Assignees
Milestone

Comments

@jubilee2
Copy link

The getNodeValue method currently supports retrieving the value of 'overflow'. This issue requests the addition of support for the 'outflow' property, which is distinct from 'overflow' and serves different purposes.

Expected Behavior

The method should allow users to retrieve values for both 'overflow' and 'outflow' properties.

Actual Behavior

Currently, the method only retrieves values for 'overflow' and does not recognize 'outflow'.

Offer to Contribute

I am willing to contribute to the resolution of this issue by making a Pull Request. However, if unit tests are required, I may need guidance on how to create them effectively.

@jubilee2
Copy link
Author

jubilee2 commented Mar 19, 2024

https://github.com/USEPA/Stormwater-Management-Model/blob/develop/src/solver/swmm5.c#L1048
maybe like this

        case swmm_NODE_OUTFLOW:
        return node->outflow * UCF(FLOW);

@cbuahin cbuahin added this to the v5.3.0 milestone Mar 19, 2024
@cbuahin
Copy link
Collaborator

cbuahin commented Mar 19, 2024

@jubilee2 I am in the process of overhauling the API and advancing unit tests for them in #162 and #163. I will add this to items to include in that work. We are unable to accept pull requests at this time.

@jubilee2
Copy link
Author

Thank you @michaeltryby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants