Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Global Nav component #47

Open
2 tasks done
bignamehere opened this issue Aug 18, 2022 · 0 comments
Open
2 tasks done

Update Global Nav component #47

bignamehere opened this issue Aug 18, 2022 · 0 comments
Assignees
@bignamehere
Labels
P1

Comments

@bignamehere
Copy link
Contributor

bignamehere commented Aug 18, 2022 •
edited
Loading

Currently, the global nav component will not close a link is selected within an SPA. The goto() functionality assumes the route will change, so any routing with a dynamic ID attached will update the page, but not close the menu.

  • Update codebase to include navigateTo() method
  • nagivateTo() method will trigger menu close and goto()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bignamehere bignamehere

Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bignamehere