Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Handling of Emoji's in Messages #100

Closed
49Indium opened this issue Apr 25, 2023 · 1 comment
Closed

Consistent Handling of Emoji's in Messages #100

49Indium opened this issue Apr 25, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@49Indium
Copy link
Member

49Indium commented Apr 25, 2023

I have noticed that there are a lot of regex variants to remove/ignore emotes from discord messages. These should be placed into a central function (maybe in command_utils.py).

Some examples:

  • haiku.py: "<a?:.+?:[0-9]+?>"
  • yelling.py: ":[\w\-\+\~]+:" (does links as well)
  • cowsay.py: "<a?:\w+:\d+>"

Wow, if I had a nickel for every time I [found a regex for replacing discord emotes] ... I'd have two[three] nickels - which isn't a lot, but it's weird that it happened twice[thrice].

@49Indium 49Indium added the enhancement update an existing command or cog for some new functionality label Apr 25, 2023
@andrewj-brown andrewj-brown added the good first issue Good for newcomers label Apr 25, 2023
@andrewj-brown
Copy link
Member

Closing as a subset of #120.

@andrewj-brown andrewj-brown closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2023
@andrewj-brown andrewj-brown added duplicate This issue or pull request already exists and removed enhancement update an existing command or cog for some new functionality good first issue Good for newcomers labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants