Highlights find matches not just in records
#9105
Assignees
Labels
enhancement
New feature or request
good first issue
Good for newcomers
inconsistent-behavior
Behavior between different commands or types inconsistent/unexpected
Milestone
Comments
juanPabloMiceli
added
enhancement
juanPabloMiceli
changed the title
sholderbach
added
good first issue
sholderbach
changed the title
find matches not just in records
|
ya, i really wrote it for tables only. it would be nice if someone picked it up and added it to --regex, lists, etc. |
|
Hi! I would love to take it up as a first issue. I have just graduated and would love to start with open source. I would also appreciate some guidance! I will give this an honest effort though. |
|
@avthakore |
This was referenced Jan 7, 2024
fdncred
added a commit
that referenced
this issue
Jan 30, 2024
this PR should close #9105 # Description I have implemented highlights for find which work for all strings. The implementation also works for lists, but with exceptions (for example, it does not work for list of lists). The implementation is also not implemented for --regex. --------- Co-authored-by: Georgiana <geo@LAPTOP-EQP6H37N> Co-authored-by: Darren Schroeder <[email protected]>
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this issue
Feb 20, 2024
this PR should close nushell#9105 # Description I have implemented highlights for find which work for all strings. The implementation also works for lists, but with exceptions (for example, it does not work for list of lists). The implementation is also not implemented for --regex. --------- Co-authored-by: Georgiana <geo@LAPTOP-EQP6H37N> Co-authored-by: Darren Schroeder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related problem
When using
find, the match is only highlighted if the result comes from a record.Describe the solution you'd like
I think we should highlight at least strings and lists (maybe I am missing another Value), I gave a quick look at the code and believe it shouldn't be to hard to add this feature (citation needed).
Describe alternatives you've considered
No response
Additional context and details
No response
The text was updated successfully, but these errors were encountered: