Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added into_vec method for Matrix #3

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
11 changes: 7 additions & 4 deletions src/base/matrix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4718,23 +4718,26 @@ impl<T> super::alias::Matrix1<T> {
}
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contribution starts here

/// Provides a method for transforming a matrix into a vector
/// Provides methods for transforming a matrix into a vector with different algorithms
impl<T, R: Dim, C: Dim, S: Storage<T, R, C>> Matrix<T, R, C, S>
where
T: Clone,
{
/// Converts matrix into a vector by concatenating rows
pub fn into_vec(&self) -> Vec<T> {
let (num_rows, num_columns) = self.shape();
let mut resulted_vector = Vec::with_capacity(num_rows * num_columns);

for row in 0..num_rows {
for column in 0..num_columns {
for i in 0..num_rows {
for j in 0..num_columns {
unsafe {
resulted_vector.push(self.get_unchecked((row, column)).clone());
resulted_vector.push(self.get_unchecked((i, j)).clone());
}
}
}

return resulted_vector;
alexandruradovici marked this conversation as resolved.
Show resolved Hide resolved
}
}