All overlap #187
Closed
All overlap #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8. Add global flag to global object
xcode updates
added building zlib as optional quieted warnings on cmake build
Consolidated github workflow Added macOS to the workflow Updated readme.md to standardized cmake instructions
Feature/js upgrade
1. Updated Xcode to match other ides 2. Corrected position errors in Cmake 3. Changed case on cBaseobject.cpp to uppercase O, to match header file 4. Changed gump.h to CGump.h (since it defines the CGump.cpp class).
deleted redundant workflow (build.yml)
Change ofstream to generic ostream in calls
async region save
…to all-overlap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xuri, if you can test this please.
DANGER DANGER WILL ROBINSON
This will delete your resource[#].bin files on load (it saves text *.wsc files, just something I am playing with). So ensure it isn't run in some test data you want to keep (figured you would not anyway).
Thanks again for all your help in this. I think next I am going to try a thread pool. Constrained by fitting into the existing structure, the most time is actually spent writing the data to a stream , not the file. Oh well. The other thing I was considering of tweaking was the string stream buffer, but... That has its own pitfalls(as nothing to spool to).