Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] validate token api #115

Merged
merged 2 commits into from
May 4, 2024
Merged

[Refactor] validate token api #115

merged 2 commits into from
May 4, 2024

Conversation

uhyunglee
Copy link
Contributor

๐Ÿš€ ๊ด€๋ จ ์ด์Šˆ

  • ํ† ํฐ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ

๐Ÿ”‘ ์ฃผ์š” ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • ํ† ํฐ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ ์—๋Ÿฌ์ฝ”๋“œ ๋ถ„๋ฅ˜ ์ˆ˜์ •

โœ”๏ธ ์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋ ค๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€? (main branch์— ์‹ค์ˆ˜๋กœ PR ์ƒ์„ฑ ๊ธˆ์ง€)
  • ์ž‘์—…ํ•œ API์— ๋Œ€ํ•ด ์ ์ ˆํ•œ ์˜ˆ์™ธ์ฒ˜๋ฆฌ๊ฐ€ ์ด๋ฃจ์–ด์กŒ๋Š”๊ฐ€?
  • ์ž‘์—…ํ•œ API์— ๋Œ€ํ•ด ์ ์ ˆํ•œ ๋กœ๊ทธ ๋ฉ”์‹œ์ง€๊ฐ€ ์ž‘์„ฑ๋˜์—ˆ๋Š”๊ฐ€? (Controller๋‚˜ Service์—์„œ log.error ํ™œ์šฉ)
  • Merge ํ•˜๋ ค๋Š” PR ๋ฐ Commit๋“ค์„ ๋กœ์ปฌ์—์„œ ์‹คํ–‰ํ–ˆ์„ ๋•Œ ์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ•˜์ง€ ์•Š์•˜๋Š”๊ฐ€?

โ†—๏ธ ๊ฐœ์„  ์‚ฌํ•ญ

๐Ÿ“” ์ฐธ๊ณ  ์ž๋ฃŒ

  • ์„ ํƒ ์‚ฌํ•ญ

@uhyunglee uhyunglee merged commit 7dd5e28 into master May 4, 2024
1 check passed
@sonshn sonshn added the build ๐ŸŒ ๋ฐฐํฌ label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build ๐ŸŒ ๋ฐฐํฌ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uhyunglee @sonshn