Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logout redirect should use request port or relative URI #174

Open
ajtucker opened this issue Dec 12, 2022 · 1 comment · May be fixed by #175
Open

Logout redirect should use request port or relative URI #174

ajtucker opened this issue Dec 12, 2022 · 1 comment · May be fixed by #175

Comments

@ajtucker
Copy link
Contributor

On logging out, the user agent is redirected after a POST to some path using a 3xx response code. The Location in the response is determined from the original request, using the same scheme and host, but doesn't consider the port.

This causes problems when using a non-standard port, e.g. when not using a proxy.

Note that it appears that the Location header no longer needs to be an absolute URI. In RFC 2616 that was the case, but in newer RFC 7231 and RFC 9110 this was relaxed and Location is now a URI reference and can be relative.
@ajtucker ajtucker linked a pull request Dec 12, 2022 that will close this issue
Open
@ajtucker ajtucker linked a pull request Dec 12, 2022 that will close this issue
Redirect location port from request #175
Open
@der
Copy link
Contributor

der commented Dec 19, 2022

Some of the registry functionality (redirects, forwards) depending on having a linked proxy server, so running without a proxy server isn't officially supported. Though certainly true that for simple cases where you don't need those services then running raw can be useful for test purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redirect location port from request UKGovLD/registry-core
2 participants
@ajtucker @der