Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the tabs implementation in the commons-lib -tb/tpt app #1898

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Move the tabs implementation in the commons-lib -tb/tpt app #1898

merged 4 commits into from
Jul 9, 2024

Conversation

lucyjemutai
Copy link
Contributor

@lucyjemutai lucyjemutai commented Jul 4, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

Move the tabs implementation in the commons-lib -tb/tpt app

Screenshots

image

Related Issue

Other

@lucyjemutai lucyjemutai marked this pull request as ready for review July 8, 2024 09:03
@lucyjemutai
Copy link
Contributor Author

the build is failing.. am not sure what could be wrong

CynthiaKamau
CynthiaKamau reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnaks @lucyjemutai , please fix the failing build

@lucyjemutai lucyjemutai requested a review from CynthiaKamau July 8, 2024 11:49
hadijahkyampeire
hadijahkyampeire approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @CynthiaKamau

@hadijahkyampeire hadijahkyampeire merged commit 41f1f66 into UCSF-IGHS:dev Jul 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadijahkyampeire hadijahkyampeire hadijahkyampeire approved these changes

@CynthiaKamau CynthiaKamau Awaiting requested review from CynthiaKamau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucyjemutai @CynthiaKamau @hadijahkyampeire