Move the tabs implementation in the commons-lib -cacx #1894
Conversation
|
Please test this locally. @hadijahkyampeire , @CynthiaKamau |
There was a problem hiding this comment.
Thanks @lucyjemutai, so what needs to be done is, make a reusable component in the commons lib which we shall use for all Encounter list tabs and it should handle all the logic of getting tabs, it should only take in the json config and the package default config.
...s/esm-cervical-cancer-app/src/cervical-cancer/cacx-visits/cacx-visits-services.component.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Sorry @lucyjemutai for the earlier review, I had seen as if it was in cacx, code looks good but we need to move the tab variable logic to this new component
...s/esm-cervical-cancer-app/src/cervical-cancer/cacx-visits/cacx-visits-services.component.tsx
Outdated
Show resolved
Hide resolved
|
Maybe we should name the folder encounter-list-tabs and also name the component and scss file accordingly. |
| } | ||
|
|
||
| export const TabsComponent: React.FC<TabsComponentProps> = ({ patientUuid, configSchema }) => { | ||
| const config = useConfig(); |
There was a problem hiding this comment.
This will not work because at this point the config is for the commons lib, we need to pass the config at the package/app level since the configs are different across packages.
| </Tabs> | ||
| </div> | ||
| ); | ||
| return <TabsComponent patientUuid={patientUuid} configSchema={cacxConfigSchema} />; |
There was a problem hiding this comment.
The package config should also be passed at this point
Requirements
OHRI-123 My PR title.Summary
Move the tabs implementation in the commons-lib -cacx module
Screenshots
Related Issue
Other