Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for f-strings in logging? #127

Open
mbazzani opened this issue Jul 31, 2023 · 1 comment · May be fixed by #138
Open

Allow for f-strings in logging? #127

mbazzani opened this issue Jul 31, 2023 · 1 comment · May be fixed by #138
Labels
enhancement New feature or request question Further information is requested

Comments

@mbazzani
Copy link
Contributor

Pylint complains about it right now, but it's a lot more readable. Does it make sense to disable this pylint error and use f-strings?

@mbazzani mbazzani added enhancement New feature or request question Further information is requested labels Jul 31, 2023
@benjamin-cates
Copy link
Contributor

I think they throw a warning because logging statements aren't always printed and it's kinda a performance problem, but most of our logging statements are printed so I'm okay with disabling it

@mbazzani mbazzani linked a pull request Aug 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants