Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove progress bar from validation #123

Closed
wants to merge 7 commits into from
Closed

Remove progress bar from validation #123

wants to merge 7 commits into from

Conversation

mbazzani
Copy link
Contributor

@mbazzani
Copy link
Contributor Author

Still need to test if certain behaviors consistent with main

@mbazzani
Copy link
Contributor Author

Note: after merging main code no longer runs, probably because of Sean's broken hotfix. Branch still needs to be tested before merging

@benjamin-cates
Copy link
Contributor

benjamin-cates commented Jul 31, 2023 •
edited
Loading

I'm getting a name "time" is not defined error

benjamin-cates
benjamin-cates approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@benjamin-cates benjamin-cates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I checked that it works on wandb

Sean1572
Sean1572 requested changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@Sean1572 Sean1572 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing progress bar doesn't fix issue as issue is primarly caused by closing terminal window.

Keeping it open for now since maybe we should still remove it up we may want a deeper discussion for it.

@Sean1572
Copy link
Collaborator

@mbazzani @benjamin-cates Can we close this requestion w/out merge

@benjamin-cates
Copy link
Contributor

Yeah go ahead lmaoooo

@mbazzani
Copy link
Contributor Author

Yup

@mbazzani mbazzani closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sean1572 Sean1572 Sean1572 requested changes

@benjamin-cates benjamin-cates benjamin-cates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix wandb sweep log progress bars
3 participants
@mbazzani @benjamin-cates @Sean1572