Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-2939 delete old indices on new create #863

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Oct 22, 2024

Connected to APPS-2939

Page/Pages Created/updated: finalize.js from #APPS-2939

Notes:

  • Copied Parinita's new methods for the ES process from the ticket

Time Report:

This took me 1-2 hours to build this

Checklist:

  • I added github label for semantic versioning
  • [ ] I double checked it looks like the designs
  • [ ] I completed any required mobile breakpoint styling
  • [ ] I completed any required hover state styling
  • [ ] I included a working spec file
  • I added notes above about how long it took to build this component
  • [ ] UX has reviewed this PR
  • I assigned this PR to someone to review

@farosFreed farosFreed self-assigned this Oct 22, 2024
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/library-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Oct 22, 2024

🚀 Preview deployment available at: Netlify Preview

Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit ba887af into main Oct 24, 2024
7 checks passed
@pghorpade pghorpade deleted the APPS-2939_delete_old_es_index_when_new_created branch October 24, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants