From 711aeef06ce5bd68ade49210457576a05b848508 Mon Sep 17 00:00:00 2001 From: Axa Mei Liauw Date: Wed, 15 Nov 2023 10:58:35 -0500 Subject: [PATCH 1/3] feat: add banner for survey to all pages --- app.html | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 app.html diff --git a/app.html b/app.html new file mode 100644 index 000000000..e6d8e67de --- /dev/null +++ b/app.html @@ -0,0 +1,47 @@ + + + + + {{ HEAD }} + + + + +
+ {{ APP }} + + + + From 0bf1b1e8763aecc190a672bb394871f6a9ca8b26 Mon Sep 17 00:00:00 2001 From: pghorpade Date: Thu, 30 Nov 2023 11:53:44 -0800 Subject: [PATCH 2/3] fix: add { force:true } to scrollintoview for page anchors --- cypress/e2e/collectiondetailpage.cy.js | 2 +- cypress/e2e/collectionlistpage.cy.js | 2 +- cypress/e2e/helptopicpage.cy.js | 2 +- cypress/e2e/locationdetailpage.cy.js | 2 +- cypress/e2e/policiesdetailpage.cy.js | 2 +- cypress/e2e/policieslistpage.cy.js | 2 +- cypress/e2e/programdetailpage.cy.js | 2 +- cypress/e2e/service.cy.js | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/cypress/e2e/collectiondetailpage.cy.js b/cypress/e2e/collectiondetailpage.cy.js index 1939e2342..cd1a31589 100644 --- a/cypress/e2e/collectiondetailpage.cy.js +++ b/cypress/e2e/collectiondetailpage.cy.js @@ -14,7 +14,7 @@ describe("Collection Detail page", () => { "contain", "TEST - Title of Collection - Halloween Costumes" ) - cy.get(".page-anchor").scrollIntoView().should('be.visible') + cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/collectionlistpage.cy.js b/cypress/e2e/collectionlistpage.cy.js index bc77477f6..aea98c05b 100644 --- a/cypress/e2e/collectionlistpage.cy.js +++ b/cypress/e2e/collectionlistpage.cy.js @@ -4,7 +4,7 @@ describe("Collection Listing page", () => { // UCLA Library brand cy.get(".logo-ucla").should("be.visible") - cy.get(".page-anchor").scrollIntoView().should('be.visible') + cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') cy.percySnapshot({ widths: [768, 992, 1200] }) }) }) diff --git a/cypress/e2e/helptopicpage.cy.js b/cypress/e2e/helptopicpage.cy.js index 6cbdf79b2..ebca74f3d 100644 --- a/cypress/e2e/helptopicpage.cy.js +++ b/cypress/e2e/helptopicpage.cy.js @@ -8,7 +8,7 @@ describe("Help Topic page", () => { "contain", "Printing Practices - Simple Card 3 Up - Rich Text - Pull Quote" ) - cy.get(".page-anchor").scrollIntoView().should('be.visible') + cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/locationdetailpage.cy.js b/cypress/e2e/locationdetailpage.cy.js index 536475387..dc4c6b734 100644 --- a/cypress/e2e/locationdetailpage.cy.js +++ b/cypress/e2e/locationdetailpage.cy.js @@ -8,7 +8,7 @@ describe("Location Detail page", () => { "contain", "Louise M. Darling Biomedical Library" ) - cy.get(".page-anchor").scrollIntoView().should('be.visible') + cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/policiesdetailpage.cy.js b/cypress/e2e/policiesdetailpage.cy.js index 1ade93dc9..a75410652 100644 --- a/cypress/e2e/policiesdetailpage.cy.js +++ b/cypress/e2e/policiesdetailpage.cy.js @@ -2,7 +2,7 @@ describe("Policy Detail page", () => { it("Visits a Policy Detail Page", () => { cy.visit("about/policies/shhh") cy.get(".logo-ucla").should("be.visible") - cy.get(".page-anchor").scrollIntoView().should('be.visible') + cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/policieslistpage.cy.js b/cypress/e2e/policieslistpage.cy.js index edd380c74..b449346a3 100644 --- a/cypress/e2e/policieslistpage.cy.js +++ b/cypress/e2e/policieslistpage.cy.js @@ -7,7 +7,7 @@ describe("Policy List page", () => { "contain", "Policies" ) - cy.get(".page-anchor").scrollIntoView().should('be.visible') + cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') cy.percySnapshot({ widths: [768, 992, 1200] }) }) }) diff --git a/cypress/e2e/programdetailpage.cy.js b/cypress/e2e/programdetailpage.cy.js index 795fb105b..ce9cd9441 100644 --- a/cypress/e2e/programdetailpage.cy.js +++ b/cypress/e2e/programdetailpage.cy.js @@ -8,7 +8,7 @@ describe("Program Detail page", () => { "contain", "Digital Library Program" ) - cy.get(".page-anchor").scrollIntoView().should('be.visible') + cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/service.cy.js b/cypress/e2e/service.cy.js index 461505f30..e96fc6f98 100644 --- a/cypress/e2e/service.cy.js +++ b/cypress/e2e/service.cy.js @@ -8,7 +8,7 @@ describe("Service page", () => { "contain", `Service with all flexible page block types` ) - cy.get(".page-anchor").scrollIntoView().should('be.visible') + cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') cy.percySnapshot({ widths: [768, 992, 1200] }) }) From f8a07d813a71dd5d39aa5e0597f955f536e928eb Mon Sep 17 00:00:00 2001 From: pghorpade Date: Thu, 30 Nov 2023 13:24:43 -0800 Subject: [PATCH 3/3] fix: replace should with click on page anchor button --- cypress/e2e/collectiondetailpage.cy.js | 2 +- cypress/e2e/collectionlistpage.cy.js | 2 +- cypress/e2e/helptopicpage.cy.js | 2 +- cypress/e2e/locationdetailpage.cy.js | 2 +- cypress/e2e/policiesdetailpage.cy.js | 2 +- cypress/e2e/policieslistpage.cy.js | 2 +- cypress/e2e/programdetailpage.cy.js | 2 +- cypress/e2e/service.cy.js | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/cypress/e2e/collectiondetailpage.cy.js b/cypress/e2e/collectiondetailpage.cy.js index cd1a31589..6db335e29 100644 --- a/cypress/e2e/collectiondetailpage.cy.js +++ b/cypress/e2e/collectiondetailpage.cy.js @@ -14,7 +14,7 @@ describe("Collection Detail page", () => { "contain", "TEST - Title of Collection - Halloween Costumes" ) - cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') + cy.get(".page-anchor-content > button").scrollIntoView().click({ force:true }) cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/collectionlistpage.cy.js b/cypress/e2e/collectionlistpage.cy.js index aea98c05b..76e440e9d 100644 --- a/cypress/e2e/collectionlistpage.cy.js +++ b/cypress/e2e/collectionlistpage.cy.js @@ -4,7 +4,7 @@ describe("Collection Listing page", () => { // UCLA Library brand cy.get(".logo-ucla").should("be.visible") - cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') + cy.get(".page-anchor").scrollIntoView().click({ force:true }) cy.percySnapshot({ widths: [768, 992, 1200] }) }) }) diff --git a/cypress/e2e/helptopicpage.cy.js b/cypress/e2e/helptopicpage.cy.js index ebca74f3d..5369061e0 100644 --- a/cypress/e2e/helptopicpage.cy.js +++ b/cypress/e2e/helptopicpage.cy.js @@ -8,7 +8,7 @@ describe("Help Topic page", () => { "contain", "Printing Practices - Simple Card 3 Up - Rich Text - Pull Quote" ) - cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') + cy.get(".page-anchor").scrollIntoView().click({ force:true }) cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/locationdetailpage.cy.js b/cypress/e2e/locationdetailpage.cy.js index dc4c6b734..a277c8382 100644 --- a/cypress/e2e/locationdetailpage.cy.js +++ b/cypress/e2e/locationdetailpage.cy.js @@ -8,7 +8,7 @@ describe("Location Detail page", () => { "contain", "Louise M. Darling Biomedical Library" ) - cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') + cy.get(".page-anchor").scrollIntoView().click({ force:true }) cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/policiesdetailpage.cy.js b/cypress/e2e/policiesdetailpage.cy.js index a75410652..009514062 100644 --- a/cypress/e2e/policiesdetailpage.cy.js +++ b/cypress/e2e/policiesdetailpage.cy.js @@ -2,7 +2,7 @@ describe("Policy Detail page", () => { it("Visits a Policy Detail Page", () => { cy.visit("about/policies/shhh") cy.get(".logo-ucla").should("be.visible") - cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') + cy.get(".page-anchor").scrollIntoView().click({ force:true }) cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/policieslistpage.cy.js b/cypress/e2e/policieslistpage.cy.js index b449346a3..cd35623b0 100644 --- a/cypress/e2e/policieslistpage.cy.js +++ b/cypress/e2e/policieslistpage.cy.js @@ -7,7 +7,7 @@ describe("Policy List page", () => { "contain", "Policies" ) - cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') + cy.get(".page-anchor").scrollIntoView().click({ force:true }) cy.percySnapshot({ widths: [768, 992, 1200] }) }) }) diff --git a/cypress/e2e/programdetailpage.cy.js b/cypress/e2e/programdetailpage.cy.js index ce9cd9441..58f2f4450 100644 --- a/cypress/e2e/programdetailpage.cy.js +++ b/cypress/e2e/programdetailpage.cy.js @@ -8,7 +8,7 @@ describe("Program Detail page", () => { "contain", "Digital Library Program" ) - cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') + cy.get(".page-anchor").scrollIntoView().click({ force:true }) cy.percySnapshot({ widths: [768, 992, 1200] }) }) diff --git a/cypress/e2e/service.cy.js b/cypress/e2e/service.cy.js index e96fc6f98..ea3c9c141 100644 --- a/cypress/e2e/service.cy.js +++ b/cypress/e2e/service.cy.js @@ -8,7 +8,7 @@ describe("Service page", () => { "contain", `Service with all flexible page block types` ) - cy.get(".page-anchor").scrollIntoView({ force:true }).should('be.visible') + cy.get(".page-anchor").scrollIntoView().click({ force:true }) cy.percySnapshot({ widths: [768, 992, 1200] }) })