Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add banner for survey to all pages #754

Merged
merged 5 commits into from
Nov 30, 2023
Merged

feat: add banner for survey to all pages #754

merged 5 commits into from
Nov 30, 2023

Conversation

axamei
Copy link
Contributor

@axamei axamei commented Nov 15, 2023

No description provided.

Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/library-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Nov 15, 2023

@github-actions github-actions bot temporarily deployed to pull_request-754 November 15, 2023 16:06 Inactive
@axamei axamei added the feature label Nov 15, 2023
@github-actions github-actions bot temporarily deployed to pull_request-754 November 15, 2023 17:39 Inactive
@axamei axamei marked this pull request as ready for review November 28, 2023 21:37
@github-actions github-actions bot temporarily deployed to pull_request-754 November 28, 2023 21:45 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-754 November 28, 2023 22:09 Inactive
pghorpade
pghorpade previously approved these changes Nov 29, 2023
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot temporarily deployed to pull_request-754 November 29, 2023 05:27 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-754 November 29, 2023 16:29 Inactive
@axamei
Copy link
Contributor Author

axamei commented Nov 29, 2023

@pghorpade I don't know why the test looking at https://uclalibrary-test.library.ucla.edu/help/printing/ is failing in the deploy preview. Can you take a look at this?

@github-actions github-actions bot temporarily deployed to pull_request-754 November 29, 2023 19:56 Inactive
@github-actions github-actions bot temporarily deployed to pull_request-754 November 30, 2023 20:00 Inactive
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit b768db9 into main Nov 30, 2023
8 checks passed
@pghorpade pghorpade deleted the UX-1074 branch November 30, 2023 21:56
sourcefilter added a commit that referenced this pull request Dec 14, 2023
sourcefilter added a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants