Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL_GPIO_EXTI_Callback function name typo #10

Open
luhouyang opened this issue Oct 11, 2024 · 0 comments
Open

HAL_GPIO_EXTI_Callback function name typo #10

luhouyang opened this issue Oct 11, 2024 · 0 comments

Comments

@luhouyang
Copy link

I'm using the Micromouse modules to prepare for a sharing session with secondary school students. It has been an amazing experience with the detailed explanation and practical guides on all the new hardware and software needed.

Something caught my attention in, I'm not sure if it is a typo or intended in Micromouse -> STM32CubeIDE Module -> Step 3: Code o’ Clock

The code written there is:

void HAL*GPIO_EXTI_Callback(uint16_t GPIO_PIN)
{
  if (GPIO_PIN == Button_Pin)
  {
    /* Your code goes here */
  }
}

However future reference of the function is HAL_GPIO_EXTI_Callback. Not sure if it is intended or there is a typo, suggest change:

void HAL_GPIO_EXTI_Callback(uint16_t GPIO_PIN)
{
  if (GPIO_PIN == Button_Pin)
  {
    /* Your code goes here */
  }
}

I have made a fork and committed the proposed changes there. fork

Thanks for the amazing work, I am thinking of learning further and maybe even joining the upcoming competition in 2025.

p.s. It is my first issue in a repository, please let me know if there's anything missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant