Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up styling on custom link components post-Athena upgrade #72

Open
cjg89 opened this issue Mar 9, 2022 · 0 comments
Open

Tidy up styling on custom link components post-Athena upgrade #72

cjg89 opened this issue Mar 9, 2022 · 0 comments
Assignees
@cjg89 @jmbarne3 @rjucf @cadie
Labels
accessibility enhancement
Milestone
v1.1.3

Comments

@cjg89
Copy link
Member

cjg89 commented Mar 9, 2022

Description

See title

Why it's Important

Some custom components will likely look a bit messy after upgrading to Athena v1.1.1 due to underlines being added to all links by default. Review these components and make adjustments as needed, while ensuring those links still provide adequate contrast to surrounding text and provide link affordance.

Alternatives

n/a

Possible Implementation

Review components and make adjustments in the theme.

Additional context

n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjg89 cjg89

@jmbarne3 jmbarne3

@rjucf rjucf

@cadie cadie

Labels
accessibility enhancement
Projects
None yet
Milestone
v1.1.3
Development

No branches or pull requests
4 participants
@cjg89 @jmbarne3 @rjucf @cadie