Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 4 Feedback #66

Open
3 tasks
negsadr opened this issue Mar 24, 2023 · 0 comments
Open
3 tasks

Milestone 4 Feedback #66

negsadr opened this issue Mar 24, 2023 · 0 comments

Comments

@negsadr
Copy link

negsadr commented Mar 24, 2023

Congratulations on finishing milestone 4! We can see you put a lot of work into this project, nice work!
Below we list some specific feedback you can use to improve your project.
We provide tick boxes for you to use in the future as you address these concerns to improve the final grade of your project.
If anything is unclear, please feel free to ask questions in this issue thread.


1. Submission instructions

rubric={mechanics:4}
Well done!

2. Improving your app

rubric={mechanics:20}
Well done!

2. Reproducibility

2.1 - Testing

rubric={mechanics:5, accuracy:5}

  • The tests are not passing in the github action workflow testing.yaml -2.5 accuracy
    Screen Shot 2023-03-24 at 7 30 52 AM

2.2 Continous Integration and Deployment

rubric={mechanics:5, accuracy:5}

  • There are no badges in the README.md. There should be one workflow badge -5 mechanics

  • The deployment workflow deploy_app.yaml is not passing. -5 accuracy

3. Tie it all together and deliver a production ready app

rubric={mechanics:20, accuracy:20, viz:10}

You are creating your production-ready Shiny app this week!
Well done!

Improve the user feedback
Well done!

Improve the documentation
The GitHub repo description in the top right corner where it says “About”:

  • The deployment of the app is not working or is giving errors. Parts of the app seem missing or fail. -4 mechanics

Comments:

  • I encountered an error:
    Screen Shot 2023-03-24 at 7 39 40 AM

  • It might be because of the size of the data but I needed to start over multiple times while working with the app as the page was stopping responding. I did not penalize you for it as it can be due to my system but there might be room for improving user experience there.

4. Reflection

rubric={reasoning:6}
Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant