From 1b07f00f0e293c87152de18f5bfc60b8da6069c6 Mon Sep 17 00:00:00 2001 From: vigneshRajakumar Date: Sat, 30 Jan 2021 17:06:13 -0500 Subject: [PATCH 1/2] add reflections and restructure cards --- src/app.R | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/src/app.R b/src/app.R index 5083ffe..5a8ebe6 100644 --- a/src/app.R +++ b/src/app.R @@ -8,7 +8,7 @@ library(plotly) #library(dashTable) -movies = read_csv("../data/processed/movies.csv") +movies = read_csv("data/processed/movies.csv") app <- Dash$new(external_stylesheets = dbcThemes$LUMEN) @@ -29,20 +29,22 @@ CONTENT_STYLE = list( "z-index" = -1 ) -cards = dbcCol(list( - dbcCard(dbcCardBody(list( - htmlH6("Average box office value", className = 'card-title'), - htmlH4(id = "average-revenue", className = 'card-text') - )), - color = "primary", - outline = TRUE), - dbcCard(dbcCardBody(list( - htmlH6("Average voting", className = 'card-title'), - htmlH4(id = "average-vote", className = 'card-text') - )), - color = "primary", - outline = TRUE) -)) +cards = dbcCardDeck( + list( + dbcCard(dbcCardBody(list( + htmlH6("Average voting", className = 'card-title'), + htmlH4(id = "average-vote", className = 'card-text') + )), + color = "primary", + outline = TRUE), + dbcCard(dbcCardBody(list( + htmlH6("Average box office value", className = 'card-title'), + htmlH4(id = "average-revenue", className = 'card-text') + )), + color = "primary", + outline = TRUE) + ) +) genre_graphs = htmlDiv(list(dbcRow(list( dbcCol(dbcCard( From ca009a4b7ccf67b4ebd5bf06b8959eced88d83c2 Mon Sep 17 00:00:00 2001 From: vigneshRajakumar Date: Sat, 30 Jan 2021 22:32:50 -0500 Subject: [PATCH 2/2] Add typo correction in reflection --- docs/reflection-milestone3.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/docs/reflection-milestone3.md b/docs/reflection-milestone3.md index 0c5ca99..a1eee36 100644 --- a/docs/reflection-milestone3.md +++ b/docs/reflection-milestone3.md @@ -17,6 +17,4 @@ The `R` implementation comes with the usage of `plotly` through `ggplotly` that The development loop of build-run-test is marginally less friendly in the `R` implementation that in `Python` since auto-updating works intermittently. Moreover, deployment with `R` is a more involved process than with `Python`. ### `Python` vs `R` Thoughts -From our experience, the major drawback of the `R` version is the more intricate deployment process. However, this we only need to learn this once and could possibly automate it. On the other hand, the major positive for the `R` version is the usage of `plotly`. However, it should be easy to re-implement the `Python` dashboard with `plotly` too. - -> talk \ No newline at end of file +From our experience, the major drawback of the `R` version is the more intricate deployment process. However, this we only need to learn this once and could possibly automate it. On the other hand, the major positive for the `R` version is the usage of `plotly`. However, it should be easy to re-implement the `Python` dashboard with `plotly` too. The `Python` implementation was more flexible and the designing of the layout was more fluent.