Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 3 Feedback #65

Open
andytai7 opened this issue Feb 5, 2021 · 1 comment
Open

Milestone 3 Feedback #65

andytai7 opened this issue Feb 5, 2021 · 1 comment

Comments

@andytai7
Copy link

andytai7 commented Feb 5, 2021

Marking:
-2 Interactive Dash app with R and ggplotly: Visualizations (Mapping and ploty controls need to be fixed)
-2 Interactive Dash app with R and ggplotly: Accuracy
-1 Interactive Dash app with R and ggplotly: Quality
-0.5 Give peer feedback to another group (Optional): Reasoning (short)

Suggestions:
Great job at implementing the app onto Dash and Plotly. The first thing I had noticed was that there were some issues with remapping the global cases figure and world map. The world map sems to be on top of the global cases. This should be fixed if R is what this group wants to use for milestone 4. This has already been mentioned in the milestone reflection, and I can see that. Some of the spacing issues on the side seem like they have been fixed. Lastly the ploty controls are on top of the titles of your figures and should be fixed with spacing for milestone 4.

@lephanthuymai
Copy link
Collaborator

Hi Andy,
Thank you very much for your feedback. We are moving forward with Python stack in Milestone 4, the layout has been significantly improved since the last milestone, I think most of your concerns have been addressed.
Best,
Mai - on behalf of group 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants