-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A test with no assertions should fail? #115
Comments
What about not fail but raise a note saying "no assertions found in this test"? Actually, for the first iteration, we can simply go with the failing option, and revisit/improve if needed later. |
To me it should be a configuration, while doing TDD I would never want a test that does not assert anything, and we are nor offering any code coverage metric, so for me a test with no assertion should be by default a test that fails, unless you can tell me a case in which this could be a problem
|
What does phpunit/jest? |
Some fail, some don't |
I found this reading phpunit docs: https://docs.phpunit.de/en/10.3/writing-tests-for-phpunit.html#incomplete-tests |
Add a configuration that allow the user to say if a test has no assertions should fail.
The text was updated successfully, but these errors were encountered: