Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from #522 don't appear on deployed docs(?) #526

Closed
penelopeysm opened this issue Oct 1, 2024 · 2 comments · Fixed by #527
Closed

Changes from #522 don't appear on deployed docs(?) #526

penelopeysm opened this issue Oct 1, 2024 · 2 comments · Fixed by #527

Comments

@penelopeysm
Copy link
Member

penelopeysm commented Oct 1, 2024

The relevant folders aren't in the gh-pages branch either. Quite stumped by this one.

The relevant action ran: https://github.com/TuringLang/docs/actions/runs/11002876308/job/30550755506

Force-pushing changes...
/usr/bin/git push --force ***github.com/TuringLang/docs.git github-pages-deploy-action/6quo49l0c:gh-pages
To https://github.com/TuringLang/docs.git
   9fb410c..e9b6e93  github-pages-deploy-action/6quo49l0c -> gh-pages
Changes committed to the gh-pages branch… 📦

However I don't see commit e9b6e93 anywhere on the branch history.

In fact 9fb410c doesn't seem to exist either.

@penelopeysm
Copy link
Member Author

It's a spectacularly impressive race condition :/

(1) I pushed to #522 which triggered this preview workflow: https://github.com/TuringLang/docs/actions/runs/11002874097/job/30550749595

(2) Then I merged it into master which triggered this build workflow: https://github.com/TuringLang/docs/actions/runs/11002876308/job/30550755506

Unfortunately, I think (2) completed before (1), so the files on the gh-pages branch were overwritten by (1).

This should be solved (at least this time round) by rerunning the build workflow (2).

@penelopeysm
Copy link
Member Author

We could probably prevent this from happening in the future by adding cancel-in-progress to the workflows.

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant