Support trans-dimensional bijectors, flatten MarkovBlanketCoveredModel
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 71.75% 72.25% +0.49%
==========================================
Files 16 16
Lines 1625 1629 +4
==========================================
+ Hits 1166 1177 +11
+ Misses 459 452 -7
☔ View full report in Codecov by Sentry. |
|
@yebai Can you please give it quick look if you have some time? The PR is not fully ready yet, but the ideas are here. |
yebai
requested changes
Sep 8, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 6137549427
💛 - Coveralls |
|
@yebai another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
param_lengthfield inModels now store a tuple of integers, which is the dimension of parameters without and with bijector transformationvar_lengthsstores the size of values of variables, both without and with transformation. Use this information to unpack the parameter vector instead of query length at run timeMarkovBlanketCoveredModelstores all the fields ofBUGSModelflatlyevaluate!!functions nowTODOs:
biratsto the tests too- [ ] add some test for using AdvancedHMC(will do this in a separate PR)