Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch un-imported Accessors in MCMCChainsExt #239

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Patch un-imported Accessors in MCMCChainsExt #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93c2f6e
patch un-imported `Accessors`
sunxd3 Nov 18, 2024
c7d5175
bump version
sunxd3 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "JuliaBUGS"
uuid = "ba9fb4c0-828e-4473-b6a1-cd2560fee5bf"
version = "0.7.0"
version = "0.7.1"

[deps]
AbstractMCMC = "80f14c24-f653-4e6a-9b94-39d6b0f70001"
Expand Down
1 change: 1 addition & 0 deletions ext/JuliaBUGSMCMCChainsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ using JuliaBUGS.AbstractPPL
using JuliaBUGS.BUGSPrimitives
using JuliaBUGS.LogDensityProblems
using JuliaBUGS.LogDensityProblemsAD
using JuliaBUGS: Accessors
using AbstractMCMC
using MCMCChains: Chains

Expand Down
32 changes: 32 additions & 0 deletions test/ext/mcmchains.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,36 @@
@test means[:beta].nt.mean[1] ≈ 2.1 atol = 0.2
@test means[:sigma].nt.mean[1] ≈ 0.9 atol = 0.2
@test means[:gen_quant].nt.mean[1] ≈ 4.2 atol = 0.2

# test for more complicated varnames
model_def = @bugs begin
A[1, 1:3] ~ Dirichlet(ones(3))
A[2, 1:3] ~ Dirichlet(ones(3))
A[3, 1:3] ~ Dirichlet(ones(3))

mu[1:3] ~ MvNormal(zeros(3), 10 * Diagonal(ones(3)))
sigma[1] ~ InverseGamma(2, 3)
sigma[2] ~ InverseGamma(2, 3)
sigma[3] ~ InverseGamma(2, 3)
end
model = compile(model_def, (;))
ad_model = ADgradient(:ReverseDiff, model; compile=Val(true))
hmc_chain = AbstractMCMC.sample(ad_model, NUTS(0.8), 10; chain_type=Chains)
@test hmc_chain.name_map[:parameters] == [
Symbol("sigma[3]"),
Symbol("sigma[2]"),
Symbol("sigma[1]"),
Symbol("mu[1:3][1]"),
Symbol("mu[1:3][2]"),
Symbol("mu[1:3][3]"),
Symbol("A[3, 1:3][1]"),
Symbol("A[3, 1:3][2]"),
Symbol("A[3, 1:3][3]"),
Symbol("A[2, 1:3][1]"),
Symbol("A[2, 1:3][2]"),
Symbol("A[2, 1:3][3]"),
Symbol("A[1, 1:3][1]"),
Symbol("A[1, 1:3][2]"),
Symbol("A[1, 1:3][3]"),
]
end
Loading