-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cumulative
and density
function
#153
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 81.78% 82.19% +0.41%
==========================================
Files 21 21
Lines 1938 1966 +28
==========================================
+ Hits 1585 1616 +31
+ Misses 353 350 -3 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 8229663147Details
💛 - Coveralls |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yebai I removed some unrelated changes, the code change should be relatively clear. I am merging this now, but if there are issue, I'll fix them later. |
deviance
function is not supported and user will be warned when using it.multibugs
: multibugs doesn't seem to supportcumulative
anddensity
, but provide individual cdf and pdf functions. We can also stop supporting these two functions, and direct user to usecdf
andpdf
.distributions
is added toBUGSModel
to track all the distributions: using Dict right now because non-scalar rv is problematic if we store distributions in the same way we store values.cumulative
anddensity
are handled in special way in_eval
function to allow access to distribution info at run time. Maybe this can be generalized, the distribution can be helpful introspect infoFix: #137