-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken case when variables are multi-dimensional and add tests for AdvancedHMC extension and inference #89
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 72.16% 71.98% -0.18%
==========================================
Files 16 16
Lines 1631 1635 +4
==========================================
Hits 1177 1177
- Misses 454 458 +4
☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 6213349923
💛 - Coveralls |
@yebai another look? |
ext/JuliaBUGSAdvancedHMCExt.jl
Outdated
t = ts[1] | ||
tstat = merge((; lp=t.z.ℓπ.value), stat(t)) | ||
tstat = merge((; lp=t.z.ℓπ.value), AdvancedHMC.stat(t)) | ||
tstat_names = collect(keys(tstat)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears these lines are the only AHMC
specific code.
If so, can we improve this module by abstracting out the AHMC
specific code into a lightweight separate extension? We can then convert this module into a generic JuliaBUGSMCMCChainsExt
which can be shared by other samplers like AMH
?
@yebai I moved the reference results to JuliaBUGS.jl/src/BUGSExamples/Volume_I/Seeds.jl Lines 41 to 48 in 6a37dfd
Also created a function at JuliaBUGS.jl/src/BUGSExamples/BUGSExamples.jl Lines 55 to 61 in 6a37dfd
Maybe something like has_ground_truth(::Val{:seeds}) = true
# call
has_ground_truth(Val(:seeds)) is better? For now, I'll merge this PR, we can improve in the future. |
Fix #71.