Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parser for BUGS #52

Merged
merged 33 commits into from
Aug 7, 2023
Merged

Add a parser for BUGS #52

merged 33 commits into from
Aug 7, 2023

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Jul 23, 2023

No description provided.

parser/parser.jl Outdated Show resolved Hide resolved
parser/parser.jl Outdated Show resolved Hide resolved
parser/parser.jl Outdated Show resolved Hide resolved
parser/parser.jl Outdated Show resolved Hide resolved
parser/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2023

Pull Request Test Coverage Report for Build 5657590403

  • 3 of 261 (1.15%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-12.9%) to 52.548%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/graphs.jl 3 5 60.0%
src/parser.jl 0 256 0.0%
Files with Coverage Reduction New Missed Lines %
src/graphs.jl 1 68.66%
Totals Coverage Status
Change from base Build 5653734998: -12.9%
Covered Lines: 691
Relevant Lines: 1315

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 91.81% and project coverage change: +6.21% 🎉

Comparison is base (f953d87) 65.40% compared to head (5315921) 71.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   65.40%   71.61%   +6.21%     
==========================================
  Files          12       13       +1     
  Lines        1055     1395     +340     
==========================================
+ Hits          690      999     +309     
- Misses        365      396      +31     
Files Changed Coverage Δ
src/BUGSExamples/BUGSExamples.jl 100.00% <ø> (ø)
src/JuliaBUGS.jl 94.87% <ø> (ø)
src/node_functions.jl 92.89% <ø> (ø)
src/graphs.jl 68.66% <60.00%> (-0.82%) ⬇️
src/bugsast.jl 56.15% <72.72%> (-0.32%) ⬇️
src/parser.jl 92.94% <92.94%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/graphs.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
src/bugsast.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
src/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
test/methadone/temp Outdated Show resolved Hide resolved
test/parser.jl Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
test/parser.jl Outdated Show resolved Hide resolved
}
"""
# # bugsmodel
# _kidney_transplants = bugsmodel"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's uncomment these tests, by prefixing the bugsmodel call:

Suggested change
# _kidney_transplants = bugsmodel"""
# _kidney_transplants = JuliaBUGS.bugsmodel"""

# df = deleteat!(df, length(names(df))) # remove END row
# CSV.write(output_filepath, df)

df = CSV.read("/home/sunxd/JuliaBUGS.jl/test/methadone/data1.csv", DataFrame)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use relative file paths instead. Also, are we running these tests currently?

@sunxd3 sunxd3 marked this pull request as ready for review August 7, 2023 14:59
@sunxd3 sunxd3 merged commit 274fca3 into master Aug 7, 2023
@sunxd3 sunxd3 deleted the parser branch August 7, 2023 14:59
@coveralls
Copy link

coveralls commented Aug 7, 2024

Pull Request Test Coverage Report for Build 5715392457

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 332 (2.71%) changed or added relevant lines in 3 files are covered.
  • 35 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-15.2%) to 50.218%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/graphs.jl 3 5 60.0%
src/bugsast.jl 6 10 60.0%
src/parser.jl 0 317 0.0%
Files with Coverage Reduction New Missed Lines %
src/graphs.jl 1 68.66%
src/JuliaBUGS.jl 2 94.87%
src/bugsast.jl 32 56.48%
Totals Coverage Status
Change from base Build 5653734998: -15.2%
Covered Lines: 691
Relevant Lines: 1376

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants