Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on DynamicPPL. #206

Closed
yebai opened this issue Jul 29, 2024 · 3 comments · Fixed by #221
Closed

Remove dependency on DynamicPPL. #206

yebai opened this issue Jul 29, 2024 · 3 comments · Fixed by #221
Assignees
Labels
enhancement New feature or request

Comments

@yebai
Copy link
Member

yebai commented Jul 29, 2024

All DynamicPPL functionality used by JuliaBUGS should probably be transferred to AbstractPPL.

@yebai yebai added the enhancement New feature or request label Jul 29, 2024
@sunxd3
Copy link
Member

sunxd3 commented Sep 2, 2024

(this reply is a draft, will edit as I go)

JuliaBUGS now uses DynamicPPL for:

  1. SimpleVarInfo and the get/set functions (these are mostly BangBang)
  2. the unflatennning functions that take a vector of values and restore them into the right size for logp evaluation

item 1, IMO can be totally removed because JuliaBUGS use a simple NamedTuple to store all the values, and varnames in JuliaBUGS are simple and straightforward.
still a lot of merits in using SimpleVarInfo, so good idea to transfer the code to AbstractPPL.

item 2, this is common code that can be shared by JuliaBUGS and DynamicPPL. these code can live in AbstractPPL.jl or Bijectors.jl

@yebai
Copy link
Member Author

yebai commented Sep 2, 2024

cc @mhauru and @penelopeysm

@yebai
Copy link
Member Author

yebai commented Sep 2, 2024

My view is that both SimpleVarInfo (also known as tracing types or effects elsewhere in the PPL literature) and VarNamedVector can eventually be transferred to AbstractPPL.

@sunxd3 sunxd3 self-assigned this Sep 16, 2024
sunxd3 added a commit that referenced this issue Oct 10, 2024
fix #206

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants