Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of DifferentiationInterface.jl? #85

Closed
willtebbutt opened this issue Aug 13, 2024 · 7 comments
Closed

Make use of DifferentiationInterface.jl? #85

willtebbutt opened this issue Aug 13, 2024 · 7 comments

Comments

@willtebbutt
Copy link
Member

Currently, there are extensions for each of the AD backends that this package supports. Would it be possibe to refactor to just make use of DifferentiationInterface, and let the user swap out the ADType so that we don't have to maintain this here?

@Red-Portal
Copy link
Member

Red-Portal commented Aug 13, 2024

I would love to, but we heavily make use of auxiliary input which requires this issue to be resolved. Until then...

@willtebbutt
Copy link
Member Author

Ahhh makes sense. I'll close this issue since it seems like you're on top of it!

@gdalle
Copy link

gdalle commented Sep 24, 2024

@Red-Portal the upcoming release of DifferentiationInterface supports auxiliary inputs, as long as only one input is active (differentiated). Wanna revisit this?

@Red-Portal
Copy link
Member

@gdalle Absolutely! Do you have a rough release date in mind?

@gdalle
Copy link

gdalle commented Sep 24, 2024

The last thing I need is for @willtebbutt to make the necessary changes to ADTypes so that we have an AutoMooncake struct, then we should be good to go

@Red-Portal Red-Portal reopened this Sep 24, 2024
@Red-Portal
Copy link
Member

Handled by #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants