Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric: Incompatible with Carpet Mod #24

Open
tesseract-two opened this issue Sep 15, 2024 · 6 comments
Open

Fabric: Incompatible with Carpet Mod #24

tesseract-two opened this issue Sep 15, 2024 · 6 comments

Comments

@tesseract-two
Copy link

tesseract-two commented Sep 15, 2024

Moonrise crashes with Carpet Mod.

Environment:

Minecraft 1.21
Fabric Loader 0.16.5
Moonrise 0.1.0-beta.2+44f8058
Carpet 1.4.147+v240613
No Telemetry 1.8.0

Carpet's Explosion_scarpetEventMixin appears to conflict with Moonrise's collisions.ExplosionMixin. Setting "required": false in Carpet's carpet.mixins.json allow the game to launch and run fine, and explosions appear to work normally.

@tesseract-two
Copy link
Author

There's also a three-way incompatibility between Carpet, Moonrise, and Lithium. It's probably related to gnembon/fabric-carpet#1937.

Tested with:

Minecraft 1.21
Fabric Loader 0.16.5
Moonrise 0.1.0-beta.2+44f8058
Lithium 0.13.0
Carpet 1.4.147+v240623 (compiled artifact linked in above PR)
No Telemetry 1.8.0

@Astropulse
Copy link

Additionally Architectury API has a similar issue with architectury.mixins.json:MixinExplosion conflicting with collisions.ExplosionMixin

@jpenilla jpenilla changed the title Incompatible with Carpet Mod Fabric: Incompatible with Carpet Mod Oct 16, 2024
@jpenilla
Copy link
Member

Is this reproducible in 1.21.3?

@Assaro
Copy link

Assaro commented Nov 23, 2024

Yes it also crashes in 1.21.3
crash-2024-11-23_22.56.01-client.txt

@jpenilla
Copy link
Member

@Assaro
Copy link

Assaro commented Nov 23, 2024

Can you try with disabling optimizedTNT in the carpet config? https://github.com/gnembon/fabric-carpet/blob/27ccd69c86c25357a2385c47db731b43ec5338b6/src/main/java/carpet/CarpetSettings.java#L231

Does this need a recompiled jar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants