Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation of Rates in GetOorU function #3

Open
davidjtgrant opened this issue Jan 30, 2022 · 0 comments
Open

Calculation of Rates in GetOorU function #3

davidjtgrant opened this issue Jan 30, 2022 · 0 comments

Comments

@davidjtgrant
Copy link

davidjtgrant commented Jan 30, 2022 •
edited
Loading

I think we are missing "brackets" in calculation of the two rates.

Charisma/api/app/main.py

Line 102 in d6c1b7b

performanceRate = sumOfSevenDayAverage - sumOfPurchasePrice / sumOfPurchasePrice

I believe it should be:
performanceRate = (sumOfSevenDayAverage - sumOfPurchasePrice) / sumOfPurchasePrice

and:

Charisma/api/app/main.py

Line 129 in d6c1b7b

historicalEthRate = currentEthPrice - ethPriceAtTimeOfFirstMint / ethPriceAtTimeOfFirstMint

I believe it should be:
historicalEthRate = (currentEthPrice - ethPriceAtTimeOfFirstMint) / ethPriceAtTimeOfFirstMint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidjtgrant