-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling #18
Comments
@Tudyx WDYT of this ? |
I'm kind of mitigated of this, I'm afraid it will deteriorate the API. For files we can panic, it will be more or less equivalent about how python handle this case. But I'm not close to this, if this is a really wanted feature I might change my mind. |
Ok I un understand your POV. |
Another detail is that in python we can throw exceptions when we get_samples, and catch it in the main program. |
Hello,
It could be really nice to add error handling while fetching.
eg. For Dataset that reads data from IO file/http .....
Currently we can only unwrap/expect.
One solution could be to allow fetch to return a Result. And then collat if all Result are Ok
Iterator then return a
Result<Batch, Self::E>
The text was updated successfully, but these errors were encountered: