Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing messages (unexplained) #381

Closed
holmesworcester opened this issue Mar 24, 2022 · 12 comments
Closed

Missing messages (unexplained) #381

holmesworcester opened this issue Mar 24, 2022 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@holmesworcester
Copy link
Contributor

holmesworcester commented Mar 24, 2022

Right now some messages never display and we don't know why. It happens with users we've seen before, not just new users.

I posted some logs to slack showing a case where this happens.

https://zbay.slack.com/files/UTAQELTJ8/F038LS34KCM/archive.zip

@holmesworcester holmesworcester added the bug Something isn't working label Mar 24, 2022
@siepra siepra self-assigned this Mar 24, 2022
@holmesworcester
Copy link
Contributor Author

the solution should include a nectar/waggle regression test for this, I think.

@holmesworcester
Copy link
Contributor Author

Related: #394

@holmesworcester holmesworcester changed the title Messages invisible when user certificate is slow to sync Missing messages (unexplained) Mar 25, 2022
@holmesworcester
Copy link
Contributor Author

Here's an example of what I'm seeing. Note that it's from an account I've already seen messages from, which invalidates the hypothesis that missing messages are only due to slowness syncing the user table.

Also, it's the older instance that is missing the messages. So there's some other issue here.

image

@holmesworcester
Copy link
Contributor Author

holmesworcester commented Mar 25, 2022

Ideas:

  • try to create nectar waggle tests where two instances fail to sync
  • try to create e2e tests where two instances fail to sync

My memory is that we've been seeing this issue for a while.

@siepra
Copy link
Contributor

siepra commented Mar 25, 2022

It seems not to be a problem with sagas' logic for verification/filtering out messages #395

@siepra siepra removed their assignment Mar 25, 2022
@holmesworcester
Copy link
Contributor Author

This happened again in Quiet alpha 5. It happened after my Mac version was reconnecting to the network after being asleep for a while. It synced some but not all new messages.

@siepra siepra self-assigned this Apr 15, 2022
@siepra siepra removed their assignment Apr 15, 2022
@EmiM
Copy link
Contributor

EmiM commented Apr 20, 2022

Have those messages never came or came but with a big lag?

Did you manage to find the repeatable way to see this problem? You wrote that it happened after computer was asleep for a while - does it always happen this way?

@siepra siepra unassigned EmiM Apr 20, 2022
@holmesworcester
Copy link
Contributor Author

holmesworcester commented Apr 20, 2022

I don't have the machine where the issue happened, so I can't say. You could possibly check to confirm this by using the files I sent you for the data directories.

I didn't manage to find steps to reproduce it.

@EmiM
Copy link
Contributor

EmiM commented Apr 25, 2022

Edit: I only could make it work on windows (aka "second machine"). I am not sure if that's because of the OS or the fact that I unplugged the ethernet cable but I couldn't make it work the other way (Linux being disconnected, Windows sending messages).

I managed to repeat the similar problem but only by disconnecting one of the Quiet apps from the network without closing it. Those are the steps I took:

  • launched 2 Quiet apps on one machine (quiet1, quiet2)
  • launched third Quiet app on second machine (quiet3)
  • made sure that they all are connected can send and receive messages
  • sent one message from quiet1
  • disconnected second machine from the network without closing the app
  • proceeded with sending messages from quiet1, made sure that quiet2 received all the messages
  • closed quiet1
  • connected second machine to the network

After quiet3 and quiet2 reconnected they were able so send and receive new messages but no replication of the past messages happened.

@EmiM
Copy link
Contributor

EmiM commented Apr 27, 2022

New discovery:
image (2)

Missing message "I received a message but Windows did not start replicating missing messages. Will it trigger now?"

The logs show that orbitdb did receive this entry but it didn't trigger replicate.progress event and that's why we are missing it in our app.
This can be a different case than the one I described in the comment above because It was triggered by reopening the quiet1 again at some point of testing.

Attaching all logs from app with the broken state and part of the logs from the app with a proper state:
app1MissingMessage.log
app2AllMessages.log
app1MissingMessagesFinalSnapshot.log

The state didn't heal on message sending nor receiving, it also didn't heal on restarting the apps. It makes sense since the entry is already saved in the local orbitdb store. However it's good news because in this case we just have to implement a mechanism that makes sure that we gathered all needed entries.

@EmiM
Copy link
Contributor

EmiM commented May 2, 2022

orbitdb-archive/orbit-db-store#122 Created issue in orbit-db-store for the case described above ^

@EmiM
Copy link
Contributor

EmiM commented May 9, 2022

We decided to close this task because we already have a workaround on our side so it should not affect user experience anymore.
Orbitdb guys don't know what can be a cause of this but they will be working on the replicator rewrite anyway so the best thing right now is to move on and wait for their refactoring.

@EmiM EmiM closed this as completed May 9, 2022
@holmesworcester holmesworcester moved this to Done in Quiet Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants