You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are currently adding support for filtering on relations.
With every case, the converter becomes:
harder to read
a little bit hacky to fulfil the cases
Reasons
everything lives in one file
the relation cases are quite challenging, the complexity is high
Goal
Try to add all relation cases and then refactor the converter.js.
We should first learn from the use cases and see which refactoring direction makes sense.
I think what we need is a detection in the code base what this case is and then react on it.
Currently, the converter.js is too generic, which makes it hard to deal with all the cases.
IMO be explicit and more readable.
The text was updated successfully, but these errors were encountered:
closes#14
- the code becomes a little hard to read, but i'd not refactor it till we have all cases in place
- this commit supports the cases listed in #14
- i've raised #17 to refactor the converter.js
Problem
We are currently adding support for filtering on relations.
With every case, the converter becomes:
Reasons
Goal
Try to add all relation cases and then refactor the converter.js.
We should first learn from the use cases and see which refactoring direction makes sense.
I think what we need is a detection in the code base what this case is and then react on it.
Currently, the converter.js is too generic, which makes it hard to deal with all the cases.
IMO be explicit and more readable.
The text was updated successfully, but these errors were encountered: