-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request - Transitions on InfoBar #23
Comments
I think this should be handled in userland rather than have fluent-svelte take opinions on this. WinUI adds no transitions, so i'm somewhat against shipping this by default. |
A simple way around this would either to add an API for exposing transitions to components (which is something i've been considering), or just using a wrapper element with the transition. |
The main problem is that Svelte prohibits using transitions on components; |
See my comment above about forwarding transitions. It's possible, similar to the actions array method, but would require a fair amount of boilerplate internally. I'm hoping that svelte will eventually implement a method of doing this natively. For now, a wrapper element should do the trick until ive made a decision. |
What about a |
This is what I have in mind more or less, and it's completely possible. The thing is that for the sake of consistency i'd need to add this to every existing component. At that point I might as well add action forwarding as well using the same technique. I'm still undecided if this is a good idea, though, but if it's clear that the svelte maintainers don't like sveltejs/rfcs#60 i'll get around to adding it. |
Right now,
<InfoBar>
components, which are supposed to display helpful notifications/information, have no loading animation, which could be nice to have.I'm thinking of something like a quick
fly
transition.The text was updated successfully, but these errors were encountered: