Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase Authentication -- Login + Sign Up Pages #38

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

meganleongg
Copy link
Contributor

Tracking Info

Resolves #28

Changes

Created the login and sign up pages with connected Firebase Authentication functionality. Formatted error messages. Uses Firestore to control which emails are valid to make accounts, so that only invited emails can sign up.

Testing

Tested validation on different emails and password test cases. Tested frontend for different screen sizes.
Message me for the env keys

Confirmation of Change

Screenshot 2024-04-23 at 2 04 49 PM Screenshot 2024-04-23 at 2 05 34 PM Screenshot 2024-04-23 at 2 06 45 PM Screenshot 2024-04-23 at 2 07 39 PM Screenshot 2024-04-23 at 2 08 08 PM

@Anthonyp0329 Anthonyp0329 requested review from a team, PiXlRAM and pratyush1718 and removed request for a team April 23, 2024 22:21
Copy link
Collaborator

@Anthonyp0329 Anthonyp0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, great work! Just some styling stuff on small screens that needs fixing, as well as file organization/ naming conventions. Also, make sure to merge in main - Pratyush's navbar changes are there so you may have to account for that.

admin-portal-frontend/src/app/signup/page.tsx Show resolved Hide resolved
admin-portal-frontend/src/app/page.tsx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login Functionality + Frontend
2 participants