Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use with react-native #88

Open
danielyaa5 opened this issue Jul 15, 2022 · 1 comment
Open

Unable to use with react-native #88

danielyaa5 opened this issue Jul 15, 2022 · 1 comment

Comments

@danielyaa5
Copy link

Hello, I was unable to use this package with react-native and I love it so much I made some changes to get it to work. https://github.com/danielyaa5/verror-2

If this is something you'd consider incorporating I will create a PR.

@bahamat
Copy link
Member

bahamat commented Aug 2, 2022

Hi, I think we'd certainly be interested in adding support, but the repo you referenced, not being a proper github fork and having no history from this repo makes it nearly impossible to evaluate.

As a first step, it would be good to add to this issue a brief description of why it doesn't work with react. Next, we'll need a github pull request citing this issue that adds the necessary support. You'll need to be sure to match code style and policies, and make sure that both make check and make test pass.

At that point, we can do a full code review, and make sure any final changes get made, and then we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants