node-sshpk#81 add support for ed25519 private keys in pkcs8 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ACK that you've run "make test" including your new one. |
danmcd
approved these changes
May 26, 2022
bahamat
requested changes
May 30, 2022
| der.startSequence(asn1.Ber.OctetString); | ||
| var k = utils.mpNormalize(key.part.k.data); | ||
| /* RFCs call for storing exactly 32 bytes, so strip any leading zeros */ | ||
| while (k.length > 32 && k[0] == 0x00) |
There was a problem hiding this comment.
jsl is complaining that this should be === not ==. If that's fixed, make check will pass.
|
Excuse me, but is this project still alive? I saw that no commits have been made since January. Thanks |
|
Yes it's still alive. It hasn't been committed because it doesn't pass style checks. |
|
@arekinath Can you please fix the CI failure? |
|
Merged in #92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC8410 (PEM/X509 formats for Ed25519 and X25519) has been finalised for a while, this is the last piece of it that wasn't implemented in
sshpkyet.Bumps version to 1.18.0 since this adds an API feature (support for converting Ed25519 keys to pkcs8 format).