Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

want ::v8whatis #111

Closed
davepacheco opened this issue Feb 28, 2018 · 2 comments
Closed

want ::v8whatis #111

davepacheco opened this issue Feb 28, 2018 · 2 comments

Comments

@davepacheco
Copy link
Contributor

See #107 for context. This ticket covers only the lower-level V8-level dcmd called ::v8whatis. This takes an address and attempts to find the V8 heap object containing that address (by looking at the memory below that address until it finds a Map, then looking to see if that address represents a valid object that would contain the target pointer).

@davepacheco
Copy link
Contributor Author

I opted not to tie this into ::whatis yet (as mentioned in #107) for two reasons: I still want to see how useful this turns out to be, and I think it might be more useful to reserve ::whatis support for a JS-level analog.

Review:
https://cr.joyent.us/#/c/3520/

PS2 is make check clean and passes all tests in "runtest_node" (all Node versions tested), including the new tests for the new dcmd.

@davepacheco
Copy link
Contributor Author

I've updated the change for a few more nits. I re-ran runtest_node (retesting all Node versions we usually test) and make check on PS3. The only issue was that I ran into #38 on the 32-bit 0.12.17 test. I re-ran it with no issues.

joyent-automation pushed a commit that referenced this issue Mar 2, 2018
#112 stack corruption in jsobj_properties()
Reviewed by: Julien Gilli <[email protected]>
Approved by: Julien Gilli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant