Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetImage unable to unmarshal response #26

Open
ChrisAubuchon opened this issue Mar 17, 2016 · 4 comments
Open

GetImage unable to unmarshal response #26

ChrisAubuchon opened this issue Mar 17, 2016 · 4 comments

Comments

@ChrisAubuchon
Copy link
Contributor

Calling GetImage fails with caused by: failed unmarshaling/decoding the response body.
The Public member of cloudapi.Image is string but a boolean is being returned.
@misterbisson
Copy link
Contributor

Is the issue as simple as updating https://github.com/joyent/gosdc/blob/master/cloudapi/images.go#L22 and the tests to match?

@ChrisAubuchon
Copy link
Contributor Author

I would think so. I don't know if it will break other things though.

@misterbisson
Copy link
Contributor

It appears to have been broken in this lib since the initial commit: https://github.com/joyent/gosdc/blame/2f11feadd2d9891e92296a1077c3e2e56939547d/cloudapi/cloudapi.go#L274

On the CloudAPI side, I traced the history of the docs to https://github.com/joyent/sdc-cloudapi/blame/1008616f7e53baed563c60e9ffcf65977c4bd30b/docs/index.md#L2772, which indicates the value has been a bool there since it was introduced in 2013.

@ChrisAubuchon
Copy link
Contributor Author

PR #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisAubuchon @misterbisson