-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show 🎄 #1258
Comments
After a lot of digging (through repos and tutorials), I found https://github.com/marketplace/actions/github-status-action-v2 to set commit statuses. This action seems to (1) still be maintained and (2) able to set statuses based on our triggering event, which is: py-ipv8/.github/workflows/pr-comment-validate.yml Lines 3 to 5 in d2d31ee
However, the Our current approach for the
|
I can't find any action to grab a SHA from a PR ref. We'll probably need a custom command and write it to an env var. The command itself should be something like the following:
The Whatever it may end up looking like: we can then set the env var and feed it to |
Lesson learned: env vars can only be used within the steps of a single job. To communicate output of jobs between jobs we need to write to |
We have had extended unit tests run on validate since 4cf28ad, lovingly referred to as the "Christmas tree". 🎄
Initially, these tests were not added as a PR check, pending assessment of their stability.
By now, these tests are stable enough to detect issues (e.g., in #1257). However, they are not shown as a PR check, so the test results are hidden for the PR author.
We should modify
.github/workflows/pr-comment-validate.yml
to report its status on the corresponding PR.The text was updated successfully, but these errors were encountered: