Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed distutils_forwardport.py #1241

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

qstokkink
Copy link
Collaborator

@qstokkink qstokkink commented Oct 20, 2023

Fixes #1239
Fixes #1240

This PR:

  • Fixes setup.py to include all of our high-level dependencies (note that apispec>=6.0.0 is an indirect dependency and is not included).
  • Removes distutils_forwardport.py from our codebase.

Notes:

  • aiohttp_apispec is now on a beta version, which is something I tried to avoid initially. Even so, this seems to be preferable over shipping distutils_forwardport.py.

@qstokkink
Copy link
Collaborator Author

validate

@qstokkink qstokkink changed the title WIP: Removed distutils_forwardport.py READY: Removed distutils_forwardport.py Oct 20, 2023
@qstokkink qstokkink marked this pull request as ready for review October 20, 2023 08:01
@qstokkink qstokkink changed the title READY: Removed distutils_forwardport.py Removed distutils_forwardport.py Oct 20, 2023
@qstokkink qstokkink merged commit 138f1dd into Tribler:master Oct 20, 2023
8 checks passed
@qstokkink qstokkink deleted the rem_distutils_fwd_port branch October 20, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependencies in setup.py Get rid of distutils_forwardport.py A.S.A.P.
2 participants