Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the validation action with IPv6 endpoints #1238

Closed
qstokkink opened this issue Oct 19, 2023 · 2 comments · Fixed by #1256
Closed

Run the validation action with IPv6 endpoints #1238

qstokkink opened this issue Oct 19, 2023 · 2 comments · Fixed by #1256
Assignees
@qstokkink
Labels
priority: low Should be addressed at some point in the future

Comments

@qstokkink
Copy link
Collaborator

Our test suite supports IPv6 addresses since #1234.

During our validation action, after the initial test run, we can set the TEST_IPV8_WITH_IPV6 environment variable and rerun the tests.
@qstokkink qstokkink added the priority: low Should be addressed at some point in the future label Oct 19, 2023
@qstokkink
Copy link
Collaborator Author

Leaving this functionality untested for too long will cause code rot. I'll upgrade the priority to "medium".

@qstokkink qstokkink added priority: medium Enhancements, features or exotic bugs and removed priority: low Should be addressed at some point in the future labels Oct 19, 2023
@qstokkink
Copy link
Collaborator Author

IPv6 tests are not stable enough to run in the validation action yet (see #1243). Scaling back down to "low".

@qstokkink qstokkink added priority: low Should be addressed at some point in the future and removed priority: medium Enhancements, features or exotic bugs labels Oct 27, 2023
@qstokkink qstokkink self-assigned this Jan 10, 2024
@qstokkink qstokkink mentioned this issue Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qstokkink qstokkink

Labels
priority: low Should be addressed at some point in the future
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed mock IPv6 address generation qstokkink/py-ipv8
1 participant
@qstokkink