What is the best way to share with the community a 1.66x filter for retroarch? #623
Replies: 5 comments 6 replies
-
|
My question was answered in March of this year in a feature request. I didn't remember that... So, from what I understand, when everything is ok, just make a PR there in retroarch |
Beta Was this translation helpful? Give feedback.
-
|
I am extremely interested in this, because i feel the NES upscale filter looks gorgeous to me, while the GB filter looks borderline unusable. Ive resorted to upscaling higher and cropping out top and bottom in a lot of games from pure spite - i would very much appreciate a new gameboy retroarch filter. So yeah just don't let this die unshared pls |
Beta Was this translation helpful? Give feedback.
-
|
It will not die without being shared. It's already 100%. I compared the result and it is the same as gambatte-dms. I just need to organize, files, names, etc and do the PR in retroarch. Before I will make a repository in my account with realease, since I don't know when this will actually be available in retroarch. |
Beta Was this translation helpful? Give feedback.
-
|
@EtherealIntellect I made a release and it's here below. I believe that tomorrow I will review something and do the PR for RetroArch. https://github.com/jeffbzrr/retroarch-1_66x-filter/releases/tag/beta |
Beta Was this translation helpful? Give feedback.
-
|
Nice :) i tried it real quick and filter seems good at first glance, i just get 20fps in retroarch without the specific optimizations of this miyoocfw build setup. I asked in the discord to confirm - you had it right, PR to retroarch, then retroarch updates, and then miyoo pulls and builds it, just like you were going to |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for confirming on discord. I didn't have this fps drop issue. I used a Q90 with the latest compiled version of Miyoo (uclibc) and the core gambatte. What is your device and firmware? What are these specific optimizations of miyoo CFW? |
Beta Was this translation helpful? Give feedback.
-
|
I'm on a v90 and an older dev version of 2.0 tbh (after usb otg but before networking)- i was gonna update again when this dropped. I just compared the retroarch i had in there with yours, and got a drop even before turning on the filter (filter didnt make things any slower tho, so thats good). About optimizations i'm not too certain, i'm just going by https://github.com/search?q=repo%3AMiyooCFW%2Fbuildroot+optimize&type=commits and the fact that on release retroarch had fairly low performance but kept improving, and I think the recommended advice is to not use the one from the retroarch website but rather the built in one in the updated cfw for some differences like this |
Beta Was this translation helpful? Give feedback.
-
|
The filter looks awesome, however I've noticed that having it enabled will make some games simply not run from the console's menu, I'm not sure why. For example, I've tried starting an NES game, and it just booted me back to the main menu of the console. If I use a different filter or no filter at all, the game starts normally. I did notice that I am able to enable the filter from the RetroArch menu and load a game from RetroArch's "load content" section, however from the menu, like I said, a crash occurs. Do you have any idea why that could be? I have encountered this issue in the following cores: I've not encountered this issue in the following cores: |
Beta Was this translation helpful? Give feedback.
-
|
I have an idea of why this happens. At the moment the filter is set to fixed output resolution for the GB/GBC context because I wanted to get the best result soon. I need to generalize this output resolution. Instead of setting a fixed value, use the input resolution multiplied by a factor. For example, in filter 2x, it's multiply by 2. It turns out that since the filter is 1.66, multiplying will not be the exact value because the result will not always be an integer depending on each core. If this is not done, I believe that errors will happen with retroarch trying to write in memory places that it should not. I'll soon see how to do that. At the moment you can use the override settings in retroarch to use this filter only in GB/GBC cores. When you're ready, let's see how the result will look for colors with different resolutions. I believe it won't be as good as for GB/GBC, due to the screen resolutions and the native ones of the emulated console. We'll see soon. Thank you for the report. |
Beta Was this translation helpful? Give feedback.
-
|
Appreciate the explanation, hopefully you're able to figure it out, I'll be looking forward to it and good luck! |
Beta Was this translation helpful? Give feedback.
-
|
I solved the missing problem and did the PR for RetroArch. I left a compiled version in my repository for anyone who wants it. |
Beta Was this translation helpful? Give feedback.
-
When btrfs was implemented in CFW, this made it practical to leave the retroarch in auto start with auto save state loading.
However, GB and GBC stay ugly in the retroarch because it doesn't have a 1.66x filter like the standalone gambatte. - I'm making this filter for the retroarch. Today I compiled everything and it was already 90% ready.
I have no experience in making contributions. Once it's 100% done, do I just push this into the retroarch project or would something be better here in that project? Is there any rule or something I should do before? I never contribute code, in open source projects, if someone can help me I appreciate it.
Beta Was this translation helpful? Give feedback.
All reactions